Fail gracefully when chromium failed to download #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install.js
Outdated
| ${revisionInfo.url} | ||
| - Extract chromium into ${revisionInfo.folderPath} | ||
| * Chromium executable should be at ${revisionInfo.executablePath} | ||
| - Alternatively, point puppeteer to the downloaded chromium with the 'executablePath' option: |
lib/Launcher.js
Outdated
| @@ -72,7 +72,7 @@ class Launcher { | |||
| if (typeof chromeExecutable !== 'string') { | |||
| let chromiumRevision = require('../package.json').puppeteer.chromium_revision; | |||
| let revisionInfo = Downloader.revisionInfo(Downloader.currentPlatform(), chromiumRevision); | |||
| console.assert(revisionInfo, 'Chromium revision is not downloaded. Run npm install'); | |||
| console.assert(revisionInfo.downloaded, `Chromium revision is not downloaded. Run "npm install", or download manually from ${revisionInfo.url} and extract into ${revisionInfo.folderPath}.`); | |||
There was a problem hiding this comment.
Let's leave this how it was. If npm install fails, it will tell them. And if chromium didn't download, then other dependencies are probably missing.
JoelEinbinder
approved these changes
Aug 21, 2017
This patch changes both install.js and Launcher.js to inform how chromium could be downloaded manually.
aslushnikov
force-pushed
the
gracefully
branch
from
cb046be
to
13329bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes both install.js and Launcher.js to inform how
chromium could be downloaded manually if puppeteer fails to download it.