feat: element option in page.accessibility.snapshot() #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
High-level questions:
|
JoelEinbinder
force-pushed
the
element_snapshot
branch
from
08728ae
to
f627776
Compare
JoelEinbinder
changed the title
JoelEinbinder
force-pushed
the
element_snapshot
branch
from
f627776
to
e979970
Compare
|
As we discussed offline, I changed the API to be part of page.accessibility.snapshot. We can look to adding something on elementHandle later. Same functionality. Pass an element to capture a snapshot rooted at that element. |
aslushnikov
reviewed
May 9, 2019
test/accessibility.spec.js
Outdated
| await page.setContent(`<button>My Button</button>`); | ||
| const button = await page.$('button'); | ||
| await page.$eval('button', button => button.remove()); | ||
| expect(await await page.accessibility.snapshot({element: button})).toEqual(null); |
| name: 'My Button' | ||
| }); | ||
|
|
||
| const input = await page.$('input'); |
There was a problem hiding this comment.
can we split this into 3 tests?
aslushnikov
approved these changes
May 10, 2019
aslushnikov
reviewed
May 10, 2019
This was referenced Feb 3, 2020
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going from AXNode -> ElementHandle is turning out to be controversial. This patch instead adds a way to go from ElementHandle -> AXNode. If the API looks good, I'll add it into Firefox as well.
#3641