Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll Chromium to r662092 #4462

Merged
merged 1 commit into from May 22, 2019

Conversation

aslushnikov
Copy link
Contributor

This roll includes:

This fixes protocol handling of UTF8 in both V8 and Chromium.

Fixes #4443.

This roll includes:
- [inspector_protocol:8ec18cf](https://chromium.googlesource.com/deps/inspector_protocol/+/8ec18cf0885bef0b5c2a922c5dc3813cbf63e962) Support STRING16 in the template when converting CBOR map keys
to protocol::Value.
- [inspector_protocol:37518ac](https://chromium.googlesource.com/deps/inspector_protocol/+/37518ac4214de146d39e324060a20b2e78673c53) fix parsing of the last ASCII character

This fixes protocol handling of UTF8 in both V8 and Chromium.

Fixes puppeteer#4443.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page.evaluate hangs on Args key has unicode char
2 participants