Basic input #45
Merged
Basic input #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
suggested changes
Jun 27, 2017
test/assets/input/textarea.html
Outdated
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>Button test</title> |
lib/Page.js
Outdated
| * @param {!Promise<number>} | ||
| */ | ||
| async _querySelector(selector) { | ||
| let documentNode = await this._client.send('DOM.getDocument', { |
There was a problem hiding this comment.
we should query for the document only once in the very beginning
lib/Page.js
Outdated
| let boxModel = (await this._client.send('DOM.getBoxModel', { | ||
| nodeId: await this._querySelector(selector) | ||
| })).model.content; | ||
| let x = Math.round((boxModel[0] + boxModel[0]) / 2); |
There was a problem hiding this comment.
this feels like an error
lib/Page.js
Outdated
| let x = Math.round((boxModel[0] + boxModel[0]) / 2); | ||
| let y = Math.round((boxModel[1] + boxModel[1]) / 2); | ||
|
|
||
| await this._client.send('Input.dispatchMouseEvent', { |
There was a problem hiding this comment.
you can await only the last one due to the serial nature of the protocol
lib/Page.js
Outdated
| * @param {!Promise} | ||
| */ | ||
| async focus(selector) { | ||
| await this.evaluate(selector => { |
There was a problem hiding this comment.
let's use DOM.querySelector and DOM.focus
lib/Page.js
Outdated
| for (let i = 0; i < text.length; i++) { | ||
| let code = text.charCodeAt(i); | ||
| let char = text.charAt(i); | ||
| await this._client.send('Input.dispatchKeyEvent', { |
There was a problem hiding this comment.
you'd probably speed this up considerably if you were to wait only for the very last one
test/assets/input/textarea.html
Outdated
| <body> | ||
| <textarea></textarea> | ||
| <script> | ||
| window.result = ""; |
aslushnikov
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43
Adds