-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic input #45
Basic input #45
Conversation
test/assets/input/textarea.html
Outdated
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<title>Button test</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text area test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
lib/Page.js
Outdated
* @param {!Promise<number>} | ||
*/ | ||
async _querySelector(selector) { | ||
let documentNode = await this._client.send('DOM.getDocument', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should query for the document only once in the very beginning
lib/Page.js
Outdated
let boxModel = (await this._client.send('DOM.getBoxModel', { | ||
nodeId: await this._querySelector(selector) | ||
})).model.content; | ||
let x = Math.round((boxModel[0] + boxModel[0]) / 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
lib/Page.js
Outdated
let x = Math.round((boxModel[0] + boxModel[0]) / 2); | ||
let y = Math.round((boxModel[1] + boxModel[1]) / 2); | ||
|
||
await this._client.send('Input.dispatchMouseEvent', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can await only the last one due to the serial nature of the protocol
lib/Page.js
Outdated
* @param {!Promise} | ||
*/ | ||
async focus(selector) { | ||
await this.evaluate(selector => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use DOM.querySelector and DOM.focus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
lib/Page.js
Outdated
for (let i = 0; i < text.length; i++) { | ||
let code = text.charCodeAt(i); | ||
let char = text.charAt(i); | ||
await this._client.send('Input.dispatchKeyEvent', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'd probably speed this up considerably if you were to wait only for the very last one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
test/assets/input/textarea.html
Outdated
<body> | ||
<textarea></textarea> | ||
<script> | ||
window.result = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
''
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
#43
Adds