feat(page): move page.pdf to protocol streams #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets transferring massive PDF files over the protocol. Fix puppeteer#4563
aslushnikov
changed the title
| /** | ||
| * @param {!Puppeteer.CDPSession} client | ||
| * @param {string} handle | ||
| * @param {?string} path |
JoelEinbinder
approved these changes
Jun 15, 2019
anirudh-mehta
added a commit
to anirudh-mehta/puppeteer-pdf
that referenced
this pull request
Jun 22, 2019
A recent pull request released as part of version 1.18 to support large pdf's in puppeteer isn't compatible with Chrome Stable version. Forcing to 1.17 PR: puppeteer/puppeteer#4587 Issue: puppeteer/puppeteer#4609
I imagine folks will complain if the API changes and it's not documented anywhere. Am I correct to assume that |
This was referenced Feb 3, 2020
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets transferring massive PDF files over the protocol.
Fix #4563