Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launcher): ensure PUPPETEER_EXECUTABLE_PATH is used if set #4677

Merged
merged 1 commit into from Jul 14, 2019
Merged

fix(launcher): ensure PUPPETEER_EXECUTABLE_PATH is used if set #4677

merged 1 commit into from Jul 14, 2019

Conversation

mohd-akram
Copy link
Contributor

Without this patch, Puppeteer exits with Error: Unsupported platform: freebsd on FreeBSD despite PUPPETEER_EXECUTABLE_PATH being set.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mohd-akram mohd-akram changed the title Fix puppeteer not always using PUPPETEER_EXECUTABLE_PATH fix(launcher): ensure PUPPETEER_EXECUTABLE_PATH is used if set Jul 6, 2019
@mohd-akram
Copy link
Contributor Author

mohd-akram commented Jul 6, 2019 via email

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants