New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(puppeteer): impl DOMWorld.$ for xpath:
selector
#5747
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need documentation as well.
Either way, we're currently investigating adding this functionality more generically, so that folks can register custom query handlers and then opt-in to them for any part of the API that accepts a selector. It seems like opting in to XPath (as opposed to using page.$x
) would be a good fit.
cc @paullewis |
We decided to go with custom query handlers instead. The implementation is currently experimental, and you can read about it here: https://github.com/puppeteer/puppeteer/releases/tag/v3.0.3 It should enable you to build what you had in mind! Please give it a try and let us know if you run into any issues. |
#5746
explicit locator strategy