Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(puppeteer): impl DOMWorld.$ for xpath: selector #5747

Closed
wants to merge 2 commits into from
Closed

feat(puppeteer): impl DOMWorld.$ for xpath: selector #5747

wants to merge 2 commits into from

Conversation

mokeyish
Copy link

@mokeyish mokeyish commented Apr 27, 2020

#5746

explicit locator strategy

图片

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mokeyish
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need documentation as well.

Either way, we're currently investigating adding this functionality more generically, so that folks can register custom query handlers and then opt-in to them for any part of the API that accepts a selector. It seems like opting in to XPath (as opposed to using page.$x) would be a good fit.

@mathiasbynens
Copy link
Member

cc @paullewis

@mathiasbynens
Copy link
Member

We decided to go with custom query handlers instead. The implementation is currently experimental, and you can read about it here: https://github.com/puppeteer/puppeteer/releases/tag/v3.0.3 It should enable you to build what you had in mind! Please give it a try and let us know if you run into any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants