chore: Revert Mitt due to breaking changes #5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuadrix
approved these changes
Jun 1, 2020
mathiasbynens
approved these changes
Jun 2, 2020
Replacing the Node EventEmitter with Mitt caused more problems than anticipated for end users due to the API differences and the amount of people who relied on the EventEmitter API. In hindsight this clearly should have been explored more and then released as a breaking v4. This commit rolls us back to the built in Node EventEmitter library which we can release to get everyone back on stable builds. We can then consider our approach to migrating to Mitt and when we do do that we can release it as a breaking change and properly document the migration strategy and approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #5944