chore: improve TS automated type tests #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
approved these changes
Feb 11, 2021
This PR: 1. Makes sure we remove and freshly install Puppeteer before testing our type defs, to avoid running on stale files. 2. Makes the tests run off `puppeteer.tgz` to avoid having version numbers in the file name and therefore having to update it when we bump versions.
jackfranklin
force-pushed
the
improve-ts-test
branch
from
a60b124
to
084a831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
type defs, to avoid running on stale files.
puppeteer.tgzto avoid having versionnumbers in the file name and therefore having to update it when we
bump versions.