Launcher: force kill chrome in case of working with temporary profile. #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - in case of user-supplied profile directory, starts gracefully closing chrome so that it doesn't corrupt profile - in case of temp profile directory, force-closes chrome and proactively tries to remove temp directory to avoid littering Fixes puppeteer#527.
|
@JoelEinbinder could you please check how this behaves on Windows? |
| process.kill(-chromeProcess.pid, 'SIGKILL'); | ||
| // Attempt to remove temporary profile directory to avoid littering. | ||
| try { | ||
| removeSync(temporaryUserDataDir); |
There was a problem hiding this comment.
shouldn't the 'close' event handle this? Or we try just in case the close never happens?
| } else { | ||
| // Terminate chrome gracefully. | ||
| if (process.platform === 'win32') | ||
| childProcess.execSync(`taskkill /pid ${chromeProcess.pid} /T`); |
There was a problem hiding this comment.
This didn't work for me on Windows.
This process can only be terminated forcefully (with /F option)
I'll send a PR with what worked for me.
JoelEinbinder
suggested changes
Sep 6, 2017
|
Closing in favor of #700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
chrome so that it doesn't corrupt profile
tries to remove temp directory to avoid littering
Fixes #527.