Revert "captureBeyondViewport as screenshot optinal param" #7065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* captureBeyondViewport as screenshot optinal param * lint fixes * fix lint * apply Emulation.setDeviceMetricsOverride in case captureBeyondViewport is false
This reverts commit ad72341.
|
Latest It would be useful to figure out why this didn't fail the CI checks on the PR, before being merged. IIUC, the commit message was not following the correct format, which our |
auto-merge was automatically disabled
April 7, 2021 10:41
Pull request was closed
|
Also, why is this described as a revert of #7063? It's just removing a line from a test rather than reverting any of the code changes. |
|
I created this PR as a revert of the original commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7063
run-checks: Some jobs were not successful: https://github.com/puppeteer/puppeteer/actions/runs/722626500