Capture native resolution while emulating. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Jul 12, 2017
lib/Browser.js
Outdated
| @@ -57,7 +57,6 @@ class Browser { | |||
| let chromiumRevision = require('../package.json').puppeteer.chromium_revision; | |||
| let revisionInfo = Downloader.revisionInfo(Downloader.currentPlatform(), chromiumRevision); | |||
| console.assert(revisionInfo, 'Chromium revision is not downloaded. Run npm install'); | |||
| this._chromeExecutable = revisionInfo.executablePath; | |||
lib/EmulatedDevice.js
Outdated
| @@ -0,0 +1,199 @@ | |||
| // Copyright 2014 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
I believe this should go under /third_party/chromium
lib/Page.js
Outdated
| @@ -260,51 +257,45 @@ class Page extends EventEmitter { | |||
| /** | |||
| * @param {string} html | |||
| * @param {!Object=} options | |||
| * @return {!Promise<!Response>} | |||
There was a problem hiding this comment.
we should keep returning the response here
lib/Page.js
Outdated
| @@ -362,7 +421,7 @@ class Page extends EventEmitter { | |||
| console.assert(Number.isInteger(options.quality), 'Expected options.quality to be an integer'); | |||
| console.assert(options.quality >= 0 && options.quality <= 100, 'Expected options.quality to be between 0 and 100 (inclusive), got ' + options.quality); | |||
| } | |||
| console.assert(!options.clip || !options.fullPage, 'options.clip and options.fullPage are exclusive'); | |||
| console.assert(!options.clip || !options['fullPage'], 'options.clip and options.fullPage are exclusive'); | |||
There was a problem hiding this comment.
let's be consistent here and use .fullPage
lib/Page.js
Outdated
|
|
||
| // Await for a single raf rountrip to ensure basic rasterization is complete. | ||
| await this.evaluate(() => { | ||
| let callback; |
There was a problem hiding this comment.
return new Promise(fulfill => requestAnimationFrame(fulfill));| /** | ||
| * @return {!Promise<!Response>} | ||
| */ | ||
| async reload() { |
There was a problem hiding this comment.
can we have reload which just navigates to the same url?
async reload(options) {
await this.navigate(this.url(), options);
}
Closed
aslushnikov
reviewed
Jul 18, 2017
lib/Page.js
Outdated
| @@ -509,36 +550,31 @@ class Page extends EventEmitter { | |||
| * @param {!Promise} | |||
| */ | |||
| async click(selector) { | |||
| let center = await this.evaluate(selector => { | |||
There was a problem hiding this comment.
this version of the method is better since it doesn't use DOM domain
lib/Page.js
Outdated
| this._viewport = viewport; | ||
| const needsReload = await EmulationManager.emulateViewport(this._client, viewport); | ||
| if (needsReload) | ||
| return this.reload(); |
lib/Page.js
Outdated
| this._viewport = viewport; | ||
| const needsReload = await EmulationManager.emulateViewport(this._client, viewport); | ||
| if (needsReload) | ||
| return this.reload(); | ||
| } | ||
|
|
||
| /** | ||
| * @return {!{width: number, height: number}} |
lib/EmulationManager.js
Outdated
|
|
||
| /** | ||
| * @param {string} name | ||
| * @return {string} |
lib/EmulationManager.js
Outdated
| ]); | ||
|
|
||
| let reloadNeeded = false; | ||
| if (viewport.hasTouch && !EmulationManager._emulatingTouch) { |
There was a problem hiding this comment.
drop _emulatingTouch so that it works in multitab world
lib/EmulationManager.js
Outdated
| } | ||
|
|
||
| if (!viewport.hasTouch && EmulationManager._emulatingTouch) { | ||
| await client.send('Runtime.removeScriptToEvaluateOnNewDocument', EmulationManager._emulatingTouch); |
There was a problem hiding this comment.
EmulationManager._emulatingTouch = false;
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.