Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(requestinterception): don't disable cache by default #7215

Closed
wants to merge 1 commit into from
Closed

feat(requestinterception): don't disable cache by default #7215

wants to merge 1 commit into from

Conversation

Androbin
Copy link
Contributor

@Androbin Androbin commented May 7, 2021

Reverts #1154 @aslushnikov disabling the cache by default.

People don't expect this behavior, see tickets like: #2905, #3403. #4055, #4620, #5176, #6915, ...

There were two reasons for this change:

This flag has been introduced in #6996.

@google-cla google-cla bot added the cla: yes label May 7, 2021
@Androbin
Copy link
Contributor Author

Androbin commented May 7, 2021

@OrKoN @jschfflr PTAL

@Androbin
Copy link
Contributor Author

Androbin commented May 7, 2021

I personally prefer #7217

@jschfflr
Copy link
Contributor

@Androbin Could you elaborate what you want to achieve here?

@Androbin
Copy link
Contributor Author

There was bug that forced us to implicitly disable the cache when enabling interception.
This flag was added to allow people to override that behavior while keeping it the default behavior.
Now the bug in question is fixed and it is safe to change the default behavior.

@Androbin
Copy link
Contributor Author

People expect interception and caching to be independent and that's how it was before #1154.

@jschfflr
Copy link
Contributor

Closing this in favor of #7215

@jschfflr jschfflr closed this May 18, 2021
@Androbin Androbin deleted the requestinterception branch May 18, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants