Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser-runner): reject promise on error #7338

Merged
merged 4 commits into from
Jul 30, 2021
Merged

fix(browser-runner): reject promise on error #7338

merged 4 commits into from
Jul 30, 2021

Commits on Jun 18, 2021

  1. fix(browser-runner): reject promise on error 

    This patch adds a reject callback to the _processClosing promise and executes it if it catches an error on removeFolderAsync(...).
    @andresrondon
    andresrondon committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    cfb02f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. chore: adding extra doc on api/browser.close()

    @andresrondon
    andresrondon committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    60a9c3a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into reject-promise-on-error

    @andresrondon
    andresrondon committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    d31e63e View commit details
    Browse the repository at this point in the history

  3. Update docs/api.md

    @mathiasbynens
    mathiasbynens committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    4409c8e View commit details
    Browse the repository at this point in the history