Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added comments for some more methods in class page #7341

Merged
merged 39 commits into from Jun 20, 2021
Merged

added comments for some more methods in class page #7341

merged 39 commits into from Jun 20, 2021

Conversation

tasneemkoushar
Copy link
Contributor

No description provided.

tasneemkoushar and others added 30 commits May 24, 2021 11:18
@tasneemkoushar
fix: modified comment for method product, platform and newPage
66cd9ad
@tasneemkoushar
fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage
380c692
@tasneemkoushar
Merge branch 'puppeteer:main' into main
fa052ff
@tasneemkoushar
fix: corrected comments for JSONValue, asElement, evaluateHandle
a512249
@tasneemkoushar
fix: corrected comments for JSONValue, asElement, evaluateHandle
d635188
@tasneemkoushar
fix: added comments for some of the method
135627b
@jackfranklin
Merge branch 'main' into main
faeaca9
@tasneemkoushar
Merge branch 'puppeteer:main' into main
b07be0b
@tasneemkoushar
fix: added proper comments
fb4fd16
@tasneemkoushar
Merge branch 'main' of https://github.com/tasneemkoushar/puppeteer in…
1fde5b2 
…to main
@tasneemkoushar
fix: added comment for some methods in page.ts
e010f9b
@tasneemkoushar
Merge branch 'puppeteer:main' into main
0f1aee5
@tasneemkoushar
fix: rectified the comments
11cf610
@tasneemkoushar
fix: changed some of the comments
ff2c3eb
@tasneemkoushar
Merge branch 'main' into main
3509b18
@tasneemkoushar
Merge branch 'main' into main
9db24e1
@tasneemkoushar
Merge branch 'main' into main
fef4d0e
@tasneemkoushar
Merge branch 'main' into main
ba4fce9
@tasneemkoushar
Merge branch 'main' into main
96ad0e4
@tasneemkoushar
fix: added comments for 3 more methods of class page
138f8b3
@tasneemkoushar
Merge branch 'puppeteer:main' into main
bfc5a04
@tasneemkoushar
Merge branch 'main' of https://github.com/tasneemkoushar/puppeteer in…
0e39e25 
…to main
@tasneemkoushar
fix: added comments for 3 more methods of class page
540eaa7
@tasneemkoushar
Merge branch 'puppeteer:main' into main
284adef
@tasneemkoushar
fix: added comments for 5 more methods in class page
3d199b1
@tasneemkoushar
Merge branch 'main' of https://github.com/tasneemkoushar/puppeteer in…
6509e3b 
…to main
@tasneemkoushar
Merge branch 'puppeteer:main' into main
9b20cca
@tasneemkoushar
fix: removed the extra whitespace
2c2d5b8
@tasneemkoushar
fix: added comments for 5 more method in page class
6b85d7c
@tasneemkoushar
fix: added comments for 5 more methods in class page
ceb9dea
@google-cla google-cla bot added the cla: yes label Jun 20, 2021
@tasneemkoushar tasneemkoushar merged commit ae440f5 into puppeteer:proper-TSDoc-comments Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfranklin jackfranklin Awaiting requested review from jackfranklin

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tasneemkoushar @jackfranklin @eltociear @juliandescottes