FIX: Fulfill promise in removeFolderAsync() - solves EPERM crash while deleting temp folder

[bdumitru]

Fix for: #6946, #298 etc. (MAJOR PRIORITY)

Problem description:
WINDOWS ONLY!
Any process involving this library would completely crash ungracefully if browser.close() is unable to delete the /temp/ folder, because the promise never gets fulfilled or rejected.
Problem tends to happen on slower computers/VMs or environments with limited access to appdata/local folder.
Issue can be hard to reproduce in a lot of cases.

Solution:
fulfill() in catch for removeFolderAsync(this._tempDirectory)
Alternative solutions:

• SIMPLE, but not ideal: throw(error) instead, remove console.error(error).
• HARDER, ideal: add WORKING runtime arguments to disable Crashpad-Metrics.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[bdumitru]

@googlebot I signed it!

[jschfflr]

It looks like this has already been addressed in #7338