Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: disallow direct access to attributes in NetworkEventManager #7826

Merged
merged 1 commit into from
Dec 9, 2021
Merged

refactor: disallow direct access to attributes in NetworkEventManager #7826

merged 1 commit into from
Dec 9, 2021

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Dec 7, 2021

No description provided.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 8, 2021

cc @benallfree

benallfree
benallfree approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@benallfree benallfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see other notes or merge as is 👍

Nice work. I went too far in my encapsulation attempt 😓

src/common/NetworkEventManager.ts Show resolved Hide resolved
src/common/NetworkEventManager.ts Outdated Show resolved Hide resolved
@OrKoN OrKoN requested a review from johanbay December 9, 2021 09:14
johanbay
johanbay approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@johanbay johanbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/NetworkEventManager.ts Outdated Show resolved Hide resolved
src/common/NetworkEventManager.ts Outdated Show resolved Hide resolved
@OrKoN OrKoN force-pushed the refactor-network-event-manager branch from 7599457 to 56c97b3 Compare December 9, 2021 09:39
@OrKoN OrKoN force-pushed the refactor-network-event-manager branch from 56c97b3 to 8d13c56 Compare December 9, 2021 09:40
@OrKoN OrKoN enabled auto-merge (squash) December 9, 2021 09:40
@OrKoN OrKoN merged commit a604646 into main Dec 9, 2021
@OrKoN OrKoN deleted the refactor-network-event-manager branch December 9, 2021 10:02
@benallfree benallfree mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benallfree benallfree benallfree approved these changes

@johanbay johanbay johanbay approved these changes

@mathiasbynens mathiasbynens Awaiting requested review from mathiasbynens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrKoN @benallfree @johanbay