Update PDFOptions.ts #8210
Closed
Update PDFOptions.ts #8210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add case options consistent with documentation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
Someone else can take this and re-do the work; barriers to contribution in this repo exceed the value of the contribution. |
OrKoN
added a commit
that referenced
this pull request
Apr 8, 2022
|
Closed in #8211 |
|
Thanks! One small tweak you might consider is to have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add case options consistent with documentation
Closes #8209 but without the test change suggested there.
What kind of change does this PR introduce?
Type change bugfix that brings code in line with documentation.
Did you add tests for your changes?
No, see comment on #8209
If relevant, did you update the documentation?
This is updating the code to match what the documentation already says.
Summary
See #8209 for the issue.
Does this PR introduce a breaking change?
No, at least not intentionally.