Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only check loading iframe in lifecycling

Merged
merged 1 commit into from May 17, 2022
Merged

fix: only check loading iframe in lifecycling #8348

merged 1 commit into from May 17, 2022

Conversation

jrandolf
Copy link
Collaborator

@jrandolf jrandolf commented May 13, 2022

This PR ensures lazy-loaded frames do not stall navigation of a frame by flagging frames that have not started loading.

@jrandolf jrandolf requested a review from OrKoN May 13, 2022
@jrandolf jrandolf enabled auto-merge (squash) May 13, 2022
Copy link
Collaborator

@OrKoN OrKoN left a comment

Could you please add the details about what issue is this fixing and why the fix is correct?

@jrandolf jrandolf changed the title fix: check lifecycle comp. on same page navigation fix: only check loading iframe in lifecycling May 16, 2022
src/common/FrameManager.ts Outdated Show resolved Hide resolved
test/frame.spec.ts Outdated Show resolved Hide resolved
test/frame.spec.ts Outdated Show resolved Hide resolved
test/frame.spec.ts Outdated Show resolved Hide resolved
test/frame.spec.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN approved these changes May 17, 2022
Copy link
Collaborator

@OrKoN OrKoN left a comment

LGTM thanks!

@jrandolf jrandolf force-pushed the nav branch 3 times, most recently from ebe37ec to cb08da0 Compare May 17, 2022
@jrandolf jrandolf disabled auto-merge May 17, 2022
@jrandolf jrandolf enabled auto-merge (squash) May 17, 2022
@jrandolf jrandolf merged commit 7438030 into main May 17, 2022
10 checks passed
@jrandolf jrandolf deleted the nav branch May 17, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants