Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recompile before funit and unit commands

Merged
merged 1 commit into from May 19, 2022
Merged

fix: recompile before funit and unit commands #8363

merged 1 commit into from May 19, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented May 18, 2022

Running only tsc-cjs does not seem sufficient for rebuilding
the project after the compat layer for ESM was introduced.
Let's run tsc-cjs-compact in addition to the existing command.

Issues: #8362

cc @whimboo

@OrKoN OrKoN requested a review from jrandolf May 18, 2022
Copy link
Collaborator

@jrandolf jrandolf left a comment

Could we run npm run build instead? Because the package.json for the es modules are not generated with just npm run tsc.

@OrKoN
Copy link
Collaborator Author

OrKoN commented May 18, 2022

I don't think we need esm modules and dts for the tests though. I am actually thinking if tsc-compat-cjs is enough (so that running tests is not super slow).

@jrandolf
Copy link
Collaborator

jrandolf commented May 18, 2022

I don't think we need esm modules and dts for the tests though. I am actually thinking if tsc-compat-cjs is enough (so that running tests is not super slow).

My concern was that node may not run because it may see ES modules even when they aren't used and complain.

@OrKoN
Copy link
Collaborator Author

OrKoN commented May 18, 2022

I don't think we need esm modules and dts for the tests though. I am actually thinking if tsc-compat-cjs is enough (so that running tests is not super slow).

My concern was that node may not run because it may see ES modules even when they aren't used and complain

Good point! Let me try with tsc-compat-cjs I think the clean up of the lib folder causes failures in the jobs.

@OrKoN OrKoN force-pushed the fix-8362 branch 3 times, most recently from c0236a3 to 2d9de70 Compare May 19, 2022
Running only tsc-cjs does not seem sufficient for rebuilding
the project after the compat layer for ESM was introduced.
Let's run `tsc` instead although it's somewhat slower.

Issues: #8362
@OrKoN OrKoN enabled auto-merge (squash) May 19, 2022
@OrKoN OrKoN merged commit 8735b78 into main May 19, 2022
10 checks passed
@OrKoN OrKoN deleted the fix-8362 branch May 19, 2022
@whimboo
Copy link
Collaborator

whimboo commented May 19, 2022

Thanks for the fix @OrKoN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants