-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: recompile before funit and unit commands #8363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we run npm run build
instead? Because the package.json
for the es modules are not generated with just npm run tsc
.
I don't think we need esm modules and dts for the tests though. I am actually thinking if |
My concern was that node may not run because it may see ES modules even when they aren't used and complain. |
Good point! Let me try with |
c0236a3
to
2d9de70
Compare
Running only tsc-cjs does not seem sufficient for rebuilding the project after the compat layer for ESM was introduced. Let's run `tsc` instead although it's somewhat slower. Issues: #8362
Thanks for the fix @OrKoN! |
Running only tsc-cjs does not seem sufficient for rebuilding
the project after the compat layer for ESM was introduced.
Let's run
tsc-cjs-compact
in addition to the existing command.Issues: #8362
cc @whimboo