Remove --no-sandbox from Docker example #838
Conversation
|
|
||
| # Uncomment to skip the chromium download when installing puppeteer. If you do, | ||
| # you'll need to launch puppeteer with: | ||
| # browser.launch({executablePath: 'google-chrome-unstable'}) | ||
| # ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true | ||
|
|
||
| # Install puppeteer so it can be required by user code that gets ran in server.js. | ||
| # Install puppeteer so it's available in the container. | ||
| RUN yarn add puppeteer |
There was a problem hiding this comment.
Shouldn't this be yarn global add puppeteer?
There was a problem hiding this comment.
It doesn't need to be right? node_modules/puppeteer will be installed in the root of the container and that will be resolvable by user code.
There was a problem hiding this comment.
Not from what I'm seeing in the resolution docs. It says it will look in the global install space folder if not found. In this case that install space is /opt/yarn which means it will look in /opt/yarn/lib/node_modules. Which it would only get there with yarn global add puppeteer.
I'm not seeing any mention of checking simply in the root file-system space for a module folder. Could be missing it though or these could not be the full chain instructions.
There was a problem hiding this comment.
Added chown -R pptruser:pptruser /node_modules works
part of #809