Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add injection framework #8862

Merged
merged 2 commits into from Aug 31, 2022
Merged

chore: add injection framework #8862

merged 2 commits into from Aug 31, 2022

Conversation

jrandolf
Copy link
Contributor

No description provided.

@jrandolf jrandolf requested a review from OrKoN August 30, 2022 12:24
@jrandolf jrandolf force-pushed the jrandolf/r2-2-7-1 branch 2 times, most recently from 2895c35 to 95ea525 Compare August 30, 2022 12:34
OrKoN
OrKoN reviewed Aug 30, 2022
View reviewed changes
src/common/IsolatedWorld.ts Outdated Show resolved Hide resolved
@jrandolf jrandolf requested a review from OrKoN August 30, 2022 12:58
@jrandolf jrandolf force-pushed the jrandolf/r2-2-7-1 branch 5 times, most recently from 236221a to 611f2fc Compare August 30, 2022 14:11
OrKoN
OrKoN reviewed Aug 30, 2022
View reviewed changes
src/common/IsolatedWorld.ts Outdated Show resolved Hide resolved
@OrKoN
Copy link
Collaborator

OrKoN commented Aug 30, 2022

Interesting, the test Cross-origin set-cookie seems to be failing consistently on this but I don't see why.

OrKoN
OrKoN reviewed Aug 30, 2022
View reviewed changes
test/src/injected.spec.ts Outdated Show resolved Hide resolved
@jrandolf jrandolf force-pushed the jrandolf/r2-2-7-1 branch 4 times, most recently from 61b4b4a to 2b8ed8b Compare August 30, 2022 18:51
@jrandolf
Copy link
Contributor Author

Interesting, the test Cross-origin set-cookie seems to be failing consistently on this but I don't see why.

The test was bad. It captured the first response which, because we evaluate something else before now, wasn't the response we were expecting. It passes now with a simply response check.

@jrandolf jrandolf enabled auto-merge (squash) August 30, 2022 18:55
OrKoN
OrKoN reviewed Aug 31, 2022
View reviewed changes
test/src/network.spec.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Aug 31, 2022
View reviewed changes
test/src/network.spec.ts Outdated Show resolved Hide resolved
@jrandolf jrandolf disabled auto-merge August 31, 2022 08:50
@jrandolf jrandolf merged commit 2922166 into main Aug 31, 2022
@jrandolf jrandolf deleted the jrandolf/r2-2-7-1 branch August 31, 2022 08:50
@jrandolf jrandolf added this to the Puppeteer Query Selectors milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Puppeteer Query Selectors
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrandolf @OrKoN