chore: add headful support for Firefox #9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Sep 22, 2022
whimboo
force-pushed
the
firefox_headful
branch
from
2ee849a
to
f847eec
Compare
whimboo
force-pushed
the
firefox_headful
branch
from
1aa6363
to
f1f3687
Compare
|
@OrKoN as it looks like headful tests are working perfectly fine now. There is only one additional test that I had to mark as skipped. |
OrKoN
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far there is only the
npm run test:firefoxcommand available that runs Puppeteer tests in Firefox with headless mode. To stay in par with Chrome this PR enables the headful mode for Firefox as well so that the following commands are available: