fix!: refactor custom query handler API #9078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
deprecate-4
branch
2 times, most recently
from
5dd93da
to
2501bb8
Compare
jrandolf
changed the title
OrKoN
reviewed
Oct 10, 2022
OrKoN
approved these changes
Oct 10, 2022
This was referenced Oct 10, 2022
Closed
Closed
Closed
Merged
This was referenced Oct 17, 2022
Closed
Closed
This was referenced Nov 2, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated query selector API from the
puppeteerinstance. Direct imports of the query selector API have also been deprecated and users are now expected to use the static methods defined onPuppeteer.