chore: fix race in test Frame.waitForFunction should work when context is destroyed #9368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OrKoN would you mind to review? Thanks! |
OrKoN
approved these changes
Dec 6, 2022
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 7, 2022
…en resolved right before execution context disposal" to fail r=webdriver-reviewers,jdescottes The test is currently broken and got fixed upstream for a later Puppeteer release: puppeteer/puppeteer#9368 Until the fix got downstreamed this test will be flaky and can pass and fail. Differential Revision: https://phabricator.services.mozilla.com/D163984
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Dec 8, 2022
…en resolved right before execution context disposal" to fail r=webdriver-reviewers,jdescottes The test is currently broken and got fixed upstream for a later Puppeteer release: puppeteer/puppeteer#9368 Until the fix got downstreamed this test will be flaky and can pass and fail. Differential Revision: https://phabricator.services.mozilla.com/D163984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the race condition which causes intermittent failures in Firefox because we haven't implemented bootstrap scripts to run on document creation.