fix: remove oopif expectations and fix oopif flakiness #9375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/remove-oopif-expectations
branch
19 times, most recently
from
a863b4e to
aad442c
Compare
OrKoN
commented
Dec 9, 2022
| #onDetachedFromTarget = (target: Target) => { | ||
| const sessionId = target._session()?.id(); | ||
|
|
||
| this.#frameManager.onDetachedFromTarget(target); |
Collaborator
Author
There was a problem hiding this comment.
This should now be redundant because we always get frameDetached event.
OrKoN
commented
Dec 9, 2022
| "parameters": ["firefox"], | ||
| "expectations": ["PASS", "FAIL"] | ||
| }, | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
I have added some common failures that have been around for a while now.
OrKoN
commented
Dec 9, 2022
| "parameters": ["chrome", "headless"], | ||
| "expectations": ["PASS", "FAIL"] | ||
| }, | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
BiDi expectation should always be last.
OrKoN
force-pushed
the
orkon/remove-oopif-expectations
branch
from
902543d to
05c8295
Compare
Lightning00Blade
approved these changes
Dec 9, 2022
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/remove-oopif-expectations
branch
from
05c8295 to
236ebb3
Compare
With M109 the flakiness should be reduced. Any present flakiness should be investigated. Drive-by: added a few flaky tests to expecations.
OrKoN
force-pushed
the
orkon/remove-oopif-expectations
branch
from
236ebb3 to
204457a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With M109 the flakiness should be reduced. Any present flakiness should be investigated.
Drive-by: a new debugging helper to debug on CI.