feat(Launcher): add devtools option #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally I think this is better solved with manually adding that flag like: puppeteer.launch({args: ['--auto-open-devtools-for-tabs']}) |
vsemozhetbyt
force-pushed
the
auto-open-devtools-for-tabs
branch
from
9f793f3
to
9ae6779
Compare
|
@paulirish The bare-bone flag is a minimalistic approach yet not very convenient.
|
paulirish
reviewed
Oct 9, 2017
lib/Launcher.js
Outdated
| @@ -80,6 +80,8 @@ class Launcher { | |||
| '--mute-audio' | |||
| ); | |||
| } | |||
| if (options.headless === false && options.devtools === true) | |||
| chromeArguments.push('--auto-open-devtools-for-tabs'); | |||
There was a problem hiding this comment.
@vsemozhetbyt we discussed and folks are comfortable with this. (including me. :)
can you also set options.headless = false automatically if devtools is true?
There was a problem hiding this comment.
I've amended. Is it OK now?
vsemozhetbyt
force-pushed
the
auto-open-devtools-for-tabs
branch
from
9ae6779
to
b7f0f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #864 (see #864 (comment))
Refs: https://peter.sh/experiments/chromium-command-line-switches/#auto-open-devtools-for-tabs
Unfortunately, I do not know if this option needs a test and how it should be tested if needed. Please, let me know what code should I add to the tests,