Refactor test expectation status for recent Firefox Nightly builds #9642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
force-pushed
the
update_expectation
branch
5 times, most recently
from
716e57a
to
bb2cb56
Compare
OrKoN
force-pushed
the
update_expectation
branch
from
bb2cb56
to
219a61a
Compare
whimboo
force-pushed
the
update_expectation
branch
from
219a61a
to
ed4e6f5
Compare
OrKoN
reviewed
Feb 10, 2023
OrKoN
approved these changes
Feb 10, 2023
whimboo
force-pushed
the
update_expectation
branch
from
ed4e6f5
to
b361ce2
Compare
|
@OrKoN the PR has been rebased and some more intermittent failures marked correctly. Should we trigger some more jobs to hardening it more? |
|
@whimboo I have restarted the jobs again. Let's land if the next run is not flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After clearing the cache of the Firefox build more tests should be able to run and pass. Lets see if this refactor of the test expectation file works.