Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): fix nits after JSHandles PR #976

Merged
merged 1 commit into from Oct 7, 2017
Merged

fix(doc): fix nits after JSHandles PR #976

merged 1 commit into from Oct 7, 2017

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Oct 7, 2017 •
edited

I am a bit confused about elementHandle.asElement(). What is its purpose and difference from jsHandle.asElement()? Should it stay? (see #976 (comment) below)

@Garbee
Copy link
Contributor

Garbee commented Oct 7, 2017

The docs look fine for those two methods in question. jsHandle returns null since it is the base class. Once elementHandle extends it, it returns the elementHandle object since it is an instance of jsHandle as the docs describe.

aslushnikov
aslushnikov approved these changes Oct 7, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@aslushnikov aslushnikov merged commit 4e55867 into puppeteer:master Oct 7, 2017
@vsemozhetbyt vsemozhetbyt deleted the doc-api-jshandles branch October 7, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsemozhetbyt @Garbee @aslushnikov