feat(Dev): Allow development under Windows platform #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Oct 10, 2017
| @@ -9,13 +9,13 @@ | |||
| }, | |||
| "scripts": { | |||
| "unit": "jasmine test/test.js", | |||
| "debug-unit": "DEBUG_TEST=true node --inspect-brk ./node_modules/.bin/jasmine test/test.js", | |||
There was a problem hiding this comment.
out of curiosity, why changing .bin/jasmine to jasmine/bin/jasmine.js?
There was a problem hiding this comment.
I had an exception:
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
^^^^^^^
SyntaxError: missing ) after argument list
This is where I found the solution https://github.com/gotwarlost/istanbul#usage-on-windows
test/test.js
Outdated
| @@ -102,7 +103,8 @@ describe('Puppeteer', function() { | |||
| await neverResolves; | |||
| expect(error.message).toContain('Protocol error'); | |||
| })); | |||
| it('userDataDir option', SX(async function() { | |||
| // Windows has issues running Chromium using a custom user data dir. It hangs when closing the browser. | |||
There was a problem hiding this comment.
This seems to be the #918
Could you please refer to the issue in the comment so that we keep track of it?
test/test.js
Outdated
| @@ -111,7 +113,7 @@ describe('Puppeteer', function() { | |||
| expect(fs.readdirSync(userDataDir).length).toBeGreaterThan(0); | |||
| rm(userDataDir); | |||
| })); | |||
| it('userDataDir argument', SX(async function() { | |||
| (windows ? xit : it)('userDataDir argument', SX(async function() { | |||
There was a problem hiding this comment.
let's refer to #918 here as well
aslushnikov
approved these changes
Oct 10, 2017
There was a problem hiding this comment.
Thanks, these are good changes. I wonder though why @JoelEinbinder didn't experience any of these during his time on Windows machine.
JoelEinbinder
approved these changes
Oct 11, 2017
This was referenced Oct 15, 2017
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
This patch improves life of puppeteer contributor on Windows: - Setting environment variables using cross-env since Windows requires the SET command. - Calling Jasmine in the script debug-unit using jasmine's JavaScript binary instead of shell. - Add /test/test-user-data-dir* to .gitignore since temporary user data directories, in case of test fails, remains in the test directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow development under Windows platform:
Problems resolved
cross-envsince Windows requires the SET command.debug-unitusing jasmine's JavaScript binary instead of shell./test/test-user-data-dir*to .gitignore since temporary user data directories, in case of test fails, remains in the test directory.Problems which didn't resolve
Output: