feat(Page): kill the page.plainText method #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The page.plainText is confusing: it's unclear what kind of text it returns, textContent or innerText. It's also easily polyfillable and doesn't seem to be used. BREAKING CHANGE: the page.plainText is not existing any more. Instead, use `page.evaluate(() => document.body.innerText)`.
JoelEinbinder
approved these changes
Oct 10, 2017
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
The page.plainText is confusing: it's unclear what kind of text it returns, textContent or innerText. It's also easily polyfillable and doesn't seem to be used. BREAKING CHANGE: the page.plainText is not existing any more. Instead, use `page.evaluate(() => document.body.innerText)`.
Kikobeats
added a commit
to microlinkhq/browserless
that referenced
this pull request
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page.plainText is confusing: it's unclear what kind of text it
returns, textContent or innerText. It's also easily polyfillable and
doesn't seem to be used.
BREAKING CHANGE: the page.plainText is not existing any more.
Instead, use
page.evaluate(() => document.body.innerText).