feat!: update min version to Node 18 (#755)

puppeteer · Feb 2, 2024 · 41c3d10 · 41c3d10
1 parent adffbeb
commit 41c3d10
Show file tree

Hide file tree

Showing 7 changed files with 310 additions and 106 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -23,7 +23,7 @@ jobs:
         # https://github.com/actions/virtual-environments#available-environments
         os: [ubuntu-latest, macos-latest, windows-latest]
         # https://github.com/nodejs/Release#release-schedule
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - name: Checkout
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.0.0

diff --git a/examples/chrome-extension-replay/Replay.js b/examples/chrome-extension-replay/Replay.js
@@ -40,15 +40,11 @@ async function main() {
   });
 
   // Emulating replay
-  document.querySelector(
-    '#recording'
-  ).innerHTML = `Running ${recording.title}<br>`;
+  document.querySelector('#recording').innerHTML =
+    `Running ${recording.title}<br>`;
   for (let i = 0; i < recording.steps.length; i++) {
-    document.querySelector(
-      '#recording'
-    ).innerHTML += `Running step ${i}: ${JSON.stringify(
-      recording.steps[i]
-    )}<br>`;
+    document.querySelector('#recording').innerHTML +=
+      `Running step ${i}: ${JSON.stringify(recording.steps[i])}<br>`;
     await new Promise((resolve) => setTimeout(resolve, 1000));
   }
 }