fix: use correct frame target (#618)

Previous PR caused a regression here that was masked by another issue. localFrame should be the one used for selectors. TargetPageOrFrame should only be used to access non-local frame. Perhaps we could refactor this in the future.
puppeteer · Jul 18, 2023 · 9a998e4 · 9a998e4
1 parent e8abd93
commit 9a998e4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/src/PuppeteerRunnerExtension.ts b/src/PuppeteerRunnerExtension.ts
@@ -124,9 +124,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
       case StepType.DoubleClick:
         await locatorRace(
           step.selectors.map((selector) => {
-            return (
-              targetPageOrFrame as unknown as InternalPage | InternalFrame
-            ).locator(selectorToPElementSelector(selector));
+            return (localFrame as unknown as InternalFrame).locator(
+              selectorToPElementSelector(selector)
+            );
           })
         )
           .setTimeout(timeout)
@@ -146,9 +146,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
       case StepType.Click:
         await locatorRace(
           step.selectors.map((selector) => {
-            return (
-              targetPageOrFrame as unknown as InternalPage | InternalFrame
-            ).locator(selectorToPElementSelector(selector));
+            return (localFrame as unknown as InternalFrame).locator(
+              selectorToPElementSelector(selector)
+            );
           })
         )
           .setTimeout(timeout)
@@ -167,9 +167,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
       case StepType.Hover:
         await locatorRace(
           step.selectors.map((selector) => {
-            return (
-              targetPageOrFrame as unknown as InternalPage | InternalFrame
-            ).locator(selectorToPElementSelector(selector));
+            return (localFrame as unknown as InternalFrame).locator(
+              selectorToPElementSelector(selector)
+            );
           })
         )
           .setTimeout(timeout)
@@ -209,9 +209,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
       case StepType.Change:
         await locatorRace(
           step.selectors.map((selector) => {
-            return (
-              targetPageOrFrame as unknown as InternalPage | InternalFrame
-            ).locator(selectorToPElementSelector(selector));
+            return (localFrame as unknown as InternalFrame).locator(
+              selectorToPElementSelector(selector)
+            );
           })
         )
           .on('action' as LocatorEmittedEvents.Action, () =>
@@ -231,9 +231,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
         if ('selectors' in step) {
           await locatorRace(
             step.selectors.map((selector) => {
-              return (
-                targetPageOrFrame as unknown as InternalPage | InternalFrame
-              ).locator(selectorToPElementSelector(selector));
+              return (localFrame as unknown as InternalFrame).locator(
+                selectorToPElementSelector(selector)
+              );
             })
           )
             .on('action' as LocatorEmittedEvents.Action, () =>

diff --git a/test/runner.test.ts b/test/runner.test.ts
@@ -218,7 +218,7 @@ describe('Runner', () => {
           },
           {
             type: StepType.Click,
-            selectors: [['.parent', '.child']],
+            selectors: ['.parent > .child'],
             offsetX: 1,
             offsetY: 1,
           },