fix: use correct frame target #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR caused a regression here that was masked by another issue. localFrame should be the one used for selectors. TargetPageOrFrame should only be used to access non-local frame. Perhaps we could refactor this in the future.
OrKoN
commented
Jul 18, 2023
| @@ -218,7 +218,7 @@ describe('Runner', () => { | |||
| }, | |||
| { | |||
| type: StepType.Click, | |||
| selectors: [['.parent', '.child']], | |||
| selectors: ['.parent > .child'], | |||
There was a problem hiding this comment.
this test case was not strictly speaking correct as there is no shadow DOM boundary in the test page => should be a normal CSS selector.
Lightning00Blade
approved these changes
Jul 18, 2023
OrKoN
pushed a commit
that referenced
this pull request
Jul 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.13.2](v2.13.1...v2.13.2) (2023-07-18) ### Bug Fixes * pierce selectors should be generated using :scope ([#613](#613)) ([e8abd93](e8abd93)) * use correct frame target ([#618](#618)) ([9a998e4](9a998e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR caused a regression here that was masked by another issue. localFrame should be the one used for selectors. TargetPageOrFrame should only be used to access non-local frame. Perhaps we could refactor this in the future.