mruby-iijson fails to build and is pulled from HEAD

[johnmccabe]

Looks like a change introduced yesterday (iij/mruby-iijson@6146eec) has resulted in mruby-iijson failing to build with this error:

CC    ../../../../../../../../../../../../../usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c -> ../../../../../../../../../../../../../usr/src/libral/build/mruby/host/mrbgems/mruby-iijson/src/json.o
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c: In function 'json_parse_number2':
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:324:39: error: expected ')' before 'MRB_PRId'
   i = snprintf(buf, sizeof(buf), "%s%"MRB_PRId"%c",
                                       ^
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
       num, ch);
       ^
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: spurious trailing '%' in format [-Wformat=]
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: spurious trailing '%' in format [-Wformat=]
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c: In function 'json_parse_number2':
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:324:39: error: expected ')' before 'MRB_PRId'
   i = snprintf(buf, sizeof(buf), "%s%"MRB_PRId"%c",
                                       ^
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
       num, ch);
       ^
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: spurious trailing '%' in format [-Wformat=]
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
/usr/src/libral/build/mruby/mrbgems/mruby-iijson/src/json.c:326:7: warning: spurious trailing '%' in format [-Wformat=]
rake aborted!

Should we be pulling from HEAD, or a specific sha (since there aren't any release tags)?

[johnmccabe]

I've raised a question on the upstream repo about that snprintf statement, in the meantime, @lutter do you have any idea what its trying to do? It doesn't look like a valid format string to me.

[lutter]

Can we close that now that upstream has fixed it ?

[johnmccabe]

Yep, forgot to do so when you merged the workaround revert.