(RE-14819) Retry failed curls before trying to gunzip them #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs testing. |
jpartlow
reviewed
Nov 1, 2022
| } | ||
| fetch_tarball_command = "cd #{host['working_dir']}; #{command_file_push}#{filename}#{extension}" | ||
| retry_on(host, fetch_tarball_command, retry_requirements) | ||
| on host, "cd #{host['working_dir']}; tar -xvf #{filename}#{extension}" |
There was a problem hiding this comment.
The only thing that comes to mind is the question of whether or not we can rely on tar being able to gunzip automagically on all platforms this method would execute on. But since I think this would only be used on pe master platforms, I don't think that's an issue.
There was a problem hiding this comment.
I went through exactly that same series of steps. I'm willing to fix it if I got it wrong.
|
Looks like this is now blocked by #207 Will wait on 🟢 before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please delete any headings that don't apply to this Pull Request (PR).