Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu 24.04 #257

Merged
merged 1 commit into from
May 31, 2024
Merged

Add support for Ubuntu 24.04 #257

merged 1 commit into from
May 31, 2024

Conversation

joshcooper
Copy link
Contributor

Ubuntu 24.04 ships a puppet-agent 8 package which uses different paths than ours. To ensure we install the correct puppet-agent package, install the specific puppet-agent artifact.

@joshcooper joshcooper requested a review from a team as a code owner May 30, 2024 23:46
Ubuntu 24.04 ships a puppet-agent 8 package which uses different paths than
ours. To ensure we install the correct puppet-agent package, install the
specific puppet-agent artifact.
@joshcooper
Copy link
Contributor Author

joshcooper commented May 31, 2024

I was able to install the expected 7.x puppet-agent package on Ubuntu 24.04.

$ cd ~/work/facter/acceptance
$ export BEAKER_PUPPET_VERSION="https://github.com/voxpupuli/beaker-puppet#install_repo"
$ export BEAKER_VERSION="~> 6.0" 
$ bundle update
$ env SHA=3eacd8cdb010b0152739539bd42d9a4ce4bd91e1 HOSTS=ubuntu2404-64a bundle exec rake ci:test:setup
...

It's not the solution we talked about during office hours... On one hand, I think there's a case to be made to always install the puppet-agent artifact we built on all platforms instead of "let's rely on the package manager to figure it out". That additional indirection and complexity means we could end up testing the wrong package as the Ubuntu 24.04 case shows (and fortunately tests failed so we knew to investigate).

It's true we're not testing the deb/rpm repos, but we weren't doing that previously and the public/final release packages are completely separate. In other words, we don't ship the per-version/sha packages publicly.

@cthorn42
Copy link
Contributor

Eventually I assume pe_repo will be updated for ubuntu 24.04, and that will cover if we are correctly pinning correctly.It isn't perfect, but it is okay if we're not testing that here.

@skyamgarp
Copy link

I also executed jenkins ad-hoc pipeline with this change.

https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/ad-hoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/

Are we expecting any specific reviews for this one? or this is good to merge?

@joshcooper joshcooper merged commit 180ce91 into main May 31, 2024
6 checks passed
@joshcooper joshcooper deleted the install_repo branch May 31, 2024 16:38
@joshcooper joshcooper changed the title Install puppet-agent directly on Ubuntu 24.04 Add support for Ubuntu 24.04 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants