New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce BEAKER_HYPERVISOR #1547
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once the line comment has been fixed up as well as these contributor items, then I'm down with getting through through our automation & merged. Thanks!
- pre-pend the commit with the
(MAINT)
string - add a line about this in the Changelog
last comment still current |
cbecea0
to
5b42a3c
Compare
I've revisited the README and expanded it into its own section with a few more examples. Also addressed the other comments. I still do wonder if this shouldn't be part of beaker-hostgenerator to use an environment variable instead of a command line option. |
5b42a3c
to
ae03d2c
Compare
How about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything here except my small note looks good, 👍 . Once that's updated, we can move this through to merging & release.
Beaker already knows how to generate hosts on the fly using beaker-hostgenrator. The problem is that there's no way to choose the default hypervisor. This means you always specify the long form. Using an environment variable we can simplify configs.
ae03d2c
to
0cbe131
Compare
Is there a beaker release planned so I can use it in my CI configs? |
Thanks! |
Beaker already knows how to generate hosts on the fly using beaker-hostgenrator. The problem is that there's no way to choose the default hypervisor. This means you always specify the long form. Using an environment variable we can simplify configs.