Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BEAKER_HYPERVISOR #1547

Merged
merged 1 commit into from Nov 19, 2018
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 9, 2018

Beaker already knows how to generate hosts on the fly using beaker-hostgenrator. The problem is that there's no way to choose the default hypervisor. This means you always specify the long form. Using an environment variable we can simplify configs.

@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@kevpl kevpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the line comment has been fixed up as well as these contributor items, then I'm down with getting through through our automation & merged. Thanks!

  • pre-pend the commit with the (MAINT) string
  • add a line about this in the Changelog

docs/tutorials/lets_write_a_test.md Outdated Show resolved Hide resolved
@kevpl
Copy link
Contributor

kevpl commented Oct 24, 2018

last comment still current

@ekohl
Copy link
Member Author

ekohl commented Oct 25, 2018

I've revisited the README and expanded it into its own section with a few more examples. Also addressed the other comments.

I still do wonder if this shouldn't be part of beaker-hostgenerator to use an environment variable instead of a command line option.

docs/tutorials/lets_write_a_test.md Outdated Show resolved Hide resolved
@ekohl
Copy link
Member Author

ekohl commented Nov 5, 2018

How about this?

Copy link
Contributor

@kevpl kevpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything here except my small note looks good, 👍 . Once that's updated, we can move this through to merging & release.

CHANGELOG.md Outdated Show resolved Hide resolved
Beaker already knows how to generate hosts on the fly using
beaker-hostgenrator. The problem is that there's no way to choose the
default hypervisor. This means you always specify the long form. Using
an environment variable we can simplify configs.
@kevpl kevpl merged commit ac97d65 into voxpupuli:master Nov 19, 2018
@ekohl ekohl deleted the beaker-hypervisor branch November 21, 2018 17:51
@ekohl
Copy link
Member Author

ekohl commented Nov 21, 2018

Is there a beaker release planned so I can use it in my CI configs?

@kevpl
Copy link
Contributor

kevpl commented Nov 26, 2018

@ekohl the next release is listed in the wiki page. Apologies that it was out-of-date due to a skipped release, but it's current now. Thanks for the ping on it!

@ekohl
Copy link
Member Author

ekohl commented Nov 26, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants