Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bolt module add should list what has changed in the puppetfile #2230

Closed
adreyer opened this issue Sep 29, 2020 · 0 comments · Fixed by #2253
Closed

bolt module add should list what has changed in the puppetfile #2230

adreyer opened this issue Sep 29, 2020 · 0 comments · Fixed by #2253
Assignees
@beechtom
Labels
Feature New features and improvements.

Comments

@adreyer
Copy link
Contributor

adreyer commented Sep 29, 2020 •
edited

Use Case

It's good to know what's changed in case something breaks after the addition. Printing this out for the user is the minimum we can do to help with this.

Should we have a confirmation step? Not for now.
Should this be a diff, or show what the new Puppetfile content is? More of a diff of just changes, not the entire contents (upgrading and downgrading versions, adding and removing modules). Refer to package managers to see what they do.

bolt module add puppetlabs-bolt
Resolving Puppetfile
....

Adding the following packages:
- A 2.3.1
- B 4.5.6

Upgrading following versions:
- C 2.3.1 to 4.5.6

Downgrading the following packages
- D 4.5.6 to 2.31.

Removing the following....
- F 2.3.1

a good json format is out of scope
@adreyer adreyer added the Feature New features and improvements. label Sep 29, 2020
@lucywyman lucywyman added this to 📝 To Do in Bolt Kanban via automation Sep 30, 2020
@beechtom beechtom self-assigned this Oct 9, 2020
@beechtom beechtom moved this from 📝 To Do to ⚡️ Doing in Bolt Kanban Oct 9, 2020
beechtom added a commit to beechtom/bolt that referenced this issue Oct 9, 2020
@beechtom
(puppetlabsGH-2230) Print Puppetfile diff when using 'module add'
81f7717 
This adds a new message to the outputter that describes changes made to
a Puppetfile when using the `bolt module add` / `Add-BoltModule`
command. The message will display which modules have been added,
removed, upgraded, and downgraded. Upgraded and downgraded modules will
have their old version and new version displayed, while added and
removed modules display the version of the module that was added or
removed.

!feature

* **Print changes made to Puppetfile when adding modules**
  ([puppetlabs#2230](puppetlabs#2230))

  The `bolt module add` command and `Add-BoltModule` cmdlet now display
  a message describing changes made to the Puppetfile, including modules
  that have been added, removed, upgraded, or downgraded.
beechtom added a commit to beechtom/bolt that referenced this issue Oct 9, 2020
@beechtom
(puppetlabsGH-2230) Print Puppetfile diff when using 'module add'
99dfd2a 
This adds a new message to the outputter that describes changes made to
a Puppetfile when using the `bolt module add` / `Add-BoltModule`
command. The message will display which modules have been added,
removed, upgraded, and downgraded. Upgraded and downgraded modules will
have their old version and new version displayed, while added and
removed modules display the version of the module that was added or
removed.

!feature

* **Print changes made to Puppetfile when adding modules**
  ([puppetlabs#2230](puppetlabs#2230))

  The `bolt module add` command and `Add-BoltModule` cmdlet now display
  a message describing changes made to the Puppetfile, including modules
  that have been added, removed, upgraded, or downgraded.
beechtom added a commit to beechtom/bolt that referenced this issue Oct 9, 2020
@beechtom
(puppetlabsGH-2230) Print Puppetfile diff when using 'module add'
738de44 
This adds a new message to the outputter that describes changes made to
a Puppetfile when using the `bolt module add` / `Add-BoltModule`
command. The message will display which modules have been added,
removed, upgraded, and downgraded. Upgraded and downgraded modules will
have their old version and new version displayed, while added and
removed modules display the version of the module that was added or
removed.

!feature

* **Print changes made to Puppetfile when adding modules**
  ([puppetlabs#2230](puppetlabs#2230))

  The `bolt module add` command and `Add-BoltModule` cmdlet now display
  a message describing changes made to the Puppetfile, including modules
  that have been added, removed, upgraded, or downgraded.
@beechtom beechtom mentioned this issue Oct 9, 2020
Merged
@beechtom beechtom linked a pull request Oct 9, 2020 that will close this issue
(GH-2230) Print Puppetfile diff when using 'module add' #2253
Merged
beechtom added a commit to beechtom/bolt that referenced this issue Oct 9, 2020
@beechtom
(puppetlabsGH-2230) Print Puppetfile diff when using 'module add'
ddefc14 
This adds a new message to the outputter that describes changes made to
a Puppetfile when using the `bolt module add` / `Add-BoltModule`
command. The message will display which modules have been added,
removed, upgraded, and downgraded. Upgraded and downgraded modules will
have their old version and new version displayed, while added and
removed modules display the version of the module that was added or
removed.

!feature

* **Print changes made to Puppetfile when adding modules**
  ([puppetlabs#2230](puppetlabs#2230))

  The `bolt module add` command and `Add-BoltModule` cmdlet now display
  a message describing changes made to the Puppetfile, including modules
  that have been added, removed, upgraded, or downgraded.
beechtom added a commit to beechtom/bolt that referenced this issue Oct 9, 2020
@beechtom
(puppetlabsGH-2230) Print Puppetfile diff when using 'module add'
51dea6d 
This adds a new message to the outputter that describes changes made to
a Puppetfile when using the `bolt module add` / `Add-BoltModule`
command. The message will display which modules have been added,
removed, upgraded, and downgraded. Upgraded and downgraded modules will
have their old version and new version displayed, while added and
removed modules display the version of the module that was added or
removed.

!feature

* **Print changes made to Puppetfile when adding modules**
  ([puppetlabs#2230](puppetlabs#2230))

  The `bolt module add` command and `Add-BoltModule` cmdlet now display
  a message describing changes made to the Puppetfile, including modules
  that have been added, removed, upgraded, or downgraded.
@beechtom beechtom moved this from ⚡️ Doing to 🚧 Reviewing in Bolt Kanban Oct 10, 2020
beechtom added a commit to beechtom/bolt that referenced this issue Oct 15, 2020
@beechtom
(puppetlabsGH-2230) Print Puppetfile diff when using 'module add'
fc69075 
This adds a new message to the outputter that describes changes made to
a Puppetfile when using the `bolt module add` / `Add-BoltModule`
command. The message will display which modules have been added,
removed, upgraded, and downgraded. Upgraded and downgraded modules will
have their old version and new version displayed, while added and
removed modules display the version of the module that was added or
removed.

!feature

* **Print changes made to Puppetfile when adding modules**
  ([puppetlabs#2230](puppetlabs#2230))

  The `bolt module add` command and `Add-BoltModule` cmdlet now display
  a message describing changes made to the Puppetfile, including modules
  that have been added, removed, upgraded, or downgraded.
beechtom added a commit that referenced this issue Oct 16, 2020
@beechtom
Merge pull request #2253 from beechtom/2230/module-add-diff
858a22a 
(GH-2230) Print Puppetfile diff when using 'module add'
@beechtom beechtom removed this from 🚧 Reviewing in Bolt Kanban Oct 16, 2020
dontlaugh pushed a commit to dontlaugh/bolt that referenced this issue Nov 22, 2020
@beechtom @dontlaugh
(puppetlabsGH-2230) Print Puppetfile diff when using 'module add'
c19264b 
This adds a new message to the outputter that describes changes made to
a Puppetfile when using the `bolt module add` / `Add-BoltModule`
command. The message will display which modules have been added,
removed, upgraded, and downgraded. Upgraded and downgraded modules will
have their old version and new version displayed, while added and
removed modules display the version of the module that was added or
removed.

!feature

* **Print changes made to Puppetfile when adding modules**
  ([puppetlabs#2230](puppetlabs#2230))

  The `bolt module add` command and `Add-BoltModule` cmdlet now display
  a message describing changes made to the Puppetfile, including modules
  that have been added, removed, upgraded, or downgraded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beechtom beechtom

Labels
Feature New features and improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-2230) Print Puppetfile diff when using 'module add' beechtom/bolt
2 participants
@adreyer @beechtom