(bug) Handle malformed _error values in task result in Orchestrator
#2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreyer
reviewed
Mar 17, 2021
lucywyman
force-pushed
the
maint-orch-exception
branch
from
32f2b4c
to
337bfbd
Compare
Previously, we assumed that if a task returned with an `_error` key that it would be a hash and include the `details` key, and that that `details` key would also have a hash value. Any of these assumptions might be wrong. This amends the Orchestrator transport to handle `_error` values that: * Are not a hash, by placing the provided value under the `message` key * Is a hash that doesn't have the `details` key by setting the details key to an empty hash * Is a hash with a `details` key that is not itself a hash by not trying to merge our own keys into it. !bug * **Handle malformed `_error` values in task results in Orchestrator** Bolt now handles `_error` from task results in the Orchestrator transport when the value of the key is not a hash, does not include the `details` key, or the `details` key is not a hash. Previously Bolt would error if any of these conditions was true.
lucywyman
force-pushed
the
maint-orch-exception
branch
from
337bfbd
to
b259881
Compare
|
Verified this isn't an issue over SSH, Windows, or Docker |
beechtom
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we assumed that if a task returned with an
_errorkey thatit would be a hash and include the
detailskey, and that thatdetailskey would also have a hash value. Any of these assumptionsmight be wrong. This amends the Orchestrator transport to handle
_errorvalues that:messagekeydetailskey by setting the detailskey to an empty hash
detailskey that is not itself a hash by not tryingto merge our own keys into it.
!bug
Handle malformed
_errorvalues in task results in OrchestratorBolt now handles
_errorfrom task results in the Orchestratortransport when the value of the key is not a hash, does not include the
detailskey, or thedetailskey is not a hash. Previously Bolt woulderror if any of these conditions was true.