(hack) Format PlanResult if it's a Bolt datatype #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucywyman
force-pushed
the
hack/better-output
branch
from
a171e36
to
4ed94f7
Compare
beechtom
reviewed
Jul 19, 2021
lucywyman
force-pushed
the
hack/better-output
branch
2 times, most recently
from
79c7ab1
to
5745408
Compare
beechtom
suggested changes
Jul 22, 2021
Bolt will format a PlanResult as JSON when we don't have a handler for the class of the result. Despite having functions for printing `Bolt::Result`, `Bolt::ApplyResult`, and `Bolt::Error` types, the plan result printer in the human outputter would not use these functions and would format the types as JSON, which often makes them difficult to read. Bolt will now correctly format the result types if returned from a plan. !feature * **Format PlanResults if they are Bolt datatypes** (hack) Bolt will now print a more human readable message for plan results that are Bolt datatypes when using the human output format, rather than printing JSON.
lucywyman
force-pushed
the
hack/better-output
branch
from
5745408
to
abd0527
Compare
beechtom
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bolt will format a PlanResult as JSON when we don't have a handler for
the class of the result. Despite having functions for printing
Bolt::Result,Bolt::ApplyResult, andBolt::Errortypes, the planresult printer in the human outputter would not use these functions and
would format the types as JSON, which often makes them difficult to
read. Bolt will now correctly format the result types if returned from a
plan.
!feature
Format PlanResults if they are Bolt datatypes (hack)
Bolt will now print a more human readable message for plan results
that are Bolt datatypes when using the human output format, rather than
printing JSON.