(PE-35920) Error when using interpolations for hiera config in plan scope #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cope Set `:avoid_hiera_interpolation_errors` to `false` so puppet will error when intepolations are attempted in plan scope.
Currently just interested in puppet 8 and ruby 3 for this PR. Want to see how PR testing goes. will revert this commit.
|
It turns out this was built on a bug in puppet 7. When using strict mode failing to find values for interpolations should not actually raise an error, instead the appropriate default should be used for lookups. Closing this, we will update the tests here when we move to taking up puppet 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
:avoid_hiera_interpolation_errorstofalseso puppet will error when intepolations are attempted in plan scope.