(maint) stop restricting bundler and ruby in Gemfile #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolt's gemspec allows ruby 2.5 and up. This is the source of truth for ruby compatability. This commit removes the versions in the Gemfile. The restriction was added to try to get rid of a warning message when using a bundler version that is too old. This is something bundler users can manage themselves if the warning is annoying them. !bug * **Stop restricting ruby version in Gemfile** The source of truth for minimum ruby version is in the gemspec. Stop duplicating that and risking conflicts in the Gemfile.
mcdonaldseanp
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bolt's gemspec allows ruby 2.5 and up. This is the source of truth for ruby compatability. This commit removes the versions in the Gemfile. The restriction was added to try to get rid of a warning message when using a bundler version that is too old. This is something bundler users can manage themselves if the warning is annoying them.
!bug
Stop restricting ruby version in Gemfile
The source of truth for minimum ruby version is in the gemspec. Stop duplicating that and risking conflicts in the Gemfile.