add shell-command and tty support to the LXD transport #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
|
End goal is to implement litmus testing with the lxd (or incus) transport. This is a blocker because the static shell command |
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Jan 29, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
7b14e9b
to
3b424a1
Compare
This was referenced Jan 30, 2024
|
reminder to self, there are no tests for lxd as it's considered experimental. |
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Feb 9, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
3b424a1
to
834a259
Compare
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Feb 9, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
834a259
to
8bbd7c1
Compare
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Feb 9, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Feb 10, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
8bbd7c1
to
8c780f3
Compare
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Feb 13, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
8c780f3
to
7e06895
Compare
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Mar 15, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
7e06895
to
793658d
Compare
h0tw1r3
added a commit
to h0tw1r3/bolt
that referenced
this pull request
Apr 17, 2024
!feature * **add shell-command and tty support to the LXD transport** ([puppetlabs#3262](puppetlabs#3262)) Previously the LXD transport would always execute commands on the target with `sh -c`. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
793658d
to
a5e8225
Compare
h0tw1r3
force-pushed
the
lxd-transport-options
branch
from
a5e8225
to
1084bfd
Compare
donoghuc
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!feature
Previously the LXD transport would always execute commands on the target with
sh -c. The shell-command and tty options are added to provide a more consistent experience between the docker, podman and lxd transports.