Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for cadir during primary cert regen #28

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Check for cadir during primary cert regen #28

merged 3 commits into from
Aug 2, 2021

Conversation

m0dular
Copy link

@m0dular m0dular commented Jul 20, 2021

Prior to this commit, regenerating the primary cert would fail on 2021
because it did not delete the signed cert from the new cadir. This
commit fixes this by adding the ssldir and cadir to an array and passing
that to find.

Copy link

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic checks out, and have tested the modified commands in isolation seem to work fine on LTS and STS

Prior to this commit, regenerating the primary cert would fail on 2021
because it did not delete the signed cert from the new cadir.  This
commit fixes this by adding the ssldir and cadir to an array and passing
that to find.
@m0dular m0dular merged commit 67753aa into puppetlabs:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants