Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-2655) Update Minimum Supported Bolt Version to 1.38.0 #49

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

henrywangpuppet
Copy link

Tested it is working since Bolt 1.38.0:

[root@pe-201819-master Boltdir]# bolt plan run ca_extend::extend_ca_cert --targets local://$(hostname -f) --run-as root
--
Starting: plan ca_extend::extend_ca_cert
Finished: plan ca_extend::extend_ca_cert in 0.0 sec
{
"kind": "bolt/pal-error",
"msg": "ca_extend::extend_ca_cert:\n  has no parameter named 'nodes'\n  expects a value for parameter 'targets'",
"details": {
}
}
[root@pe-201819-master Boltdir]# bolt --version
1.37.0

In 1.38.0:

[root@pe-201819-master Boltdir]# bolt --version
--
1.38.0
[root@pe-201819-master Boltdir]# bolt plan run ca_extend::extend_ca_cert --targets local://$(hostname -f) --run-as root
Starting: plan ca_extend::extend_ca_cert
Starting: install puppet and gather facts on pe-201819-master.puppetdebug.vlan
Finished: install puppet and gather facts with 0 failures in 3.5 sec
Starting: task facts on pe-201819-master.puppetdebug.vlan
Finished: task facts with 0 failures in 1.59 sec
Starting: task ca_extend::check_primary_cert on pe-201819-master.puppetdebug.vlan
Finished: task ca_extend::check_primary_cert with 0 failures in 0.91 sec
INFO: Stopping Puppet services on local://pe-201819-master.puppetdebug.vlan

@henrywangpuppet henrywangpuppet requested a review from a team as a code owner September 16, 2021 04:36
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2021

CLA assistant check
All committers have signed the CLA.

Copy link

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MartyEwings MartyEwings changed the title [SUP-2655 Update Minimum Supported Bolt Version to 1.38.0] (SUP-2655) Update Minimum Supported Bolt Version to 1.38.0 Sep 16, 2021
@MartyEwings MartyEwings linked an issue Sep 16, 2021 that may be closed by this pull request
@MartyEwings MartyEwings merged commit 59c3b83 into puppetlabs:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SUP-2655) Bolt version needs updated
3 participants