Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-3016) Add printing dates to agent expiry task #63

Merged
merged 1 commit into from
May 5, 2022

Conversation

elainemccloskey
Copy link

@elainemccloskey elainemccloskey commented May 5, 2022

example output before the change:

{
    "valid": [
      "/etc/puppetlabs/puppet/ssl/ca/signed/console-cert.pem",
      "/etc/puppetlabs/puppet/ssl/ca/signed/pe-compiler-886b03-0.us-west1-a.c.customer-support-scratchpad.internal.pem",
      "/etc/puppetlabs/puppet/ssl/ca/signed/pe-server-886b03-0.us-west1-a.c.customer-support-scratchpad.internal.pem",
      "/etc/puppetlabs/puppet/ssl/ca/signed/pe-server-886b03-1.us-west1-b.c.customer-support-scratchpad.internal.pem",
      "/etc/puppetlabs/puppet/ssl/ca/signed/testnode-c80ae4-0.us-west1-c.c.customer-support-scratchpad.internal.pem"
    ],
    "expiring": [

    ]
  }

And After:
{"valid": ["/etc/puppetlabs/puppet/ssl/ca/signed/console-cert.pem": Aug 4 10:29:13 2024 GMT,"/etc/puppetlabs/puppet/ssl/ca/signed/pe-compiler-886b03-0.us-west1-a.c.customer-support-scratchpad.internal.pem": May 2 10:33:06 2027 GMT,"/etc/puppetlabs/puppet/ssl/ca/signed/pe-server-886b03-0.us-west1-a.c.customer-support-scratchpad.internal.pem": Apr 29 10:27:05 2037 GMT,"/etc/puppetlabs/puppet/ssl/ca/signed/pe-server-886b03-1.us-west1-b.c.customer-support-scratchpad.internal.pem": May 2 10:33:20 2027 GMT,"/etc/puppetlabs/puppet/ssl/ca/signed/testnode-c80ae4-0.us-west1-c.c.customer-support-scratchpad.internal.pem": May 2 10:58:47 2027 GMT], "expiring": []}

@elainemccloskey elainemccloskey requested a review from a team as a code owner May 5, 2022 11:51
@MartyEwings MartyEwings added the enhancement New feature or request label May 5, 2022
@MartyEwings
Copy link

@elainemccloskey if you put some sample output from your testing here ill just approve

@elainemccloskey
Copy link
Author

elainemccloskey commented May 5, 2022

Added the output to the description, seems I have somehow removed the newline after each entry so will need to sort that....

@MartyEwings
Copy link

ok

@elainemccloskey
Copy link
Author

Changed it slighty, output is now:

  {
    "valid": [
      "/etc/puppetlabs/puppet/ssl/ca/signed/console-cert.pem: Aug  4 10:29:13 2024 GMT",
      "/etc/puppetlabs/puppet/ssl/ca/signed/pe-compiler-886b03-0.us-west1-a.c.customer-support-scratchpad.internal.pem: May  2 10:33:06 2027 GMT",
      "/etc/puppetlabs/puppet/ssl/ca/signed/pe-server-886b03-0.us-west1-a.c.customer-support-scratchpad.internal.pem: Apr 29 10:27:05 2037 GMT",
      "/etc/puppetlabs/puppet/ssl/ca/signed/pe-server-886b03-1.us-west1-b.c.customer-support-scratchpad.internal.pem: May  2 10:33:20 2027 GMT",
      "/etc/puppetlabs/puppet/ssl/ca/signed/testnode-c80ae4-0.us-west1-c.c.customer-support-scratchpad.internal.pem: May  2 10:58:47 2027 GMT"
    ],
    "expiring": [

    ]
  }

Copy link

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@MartyEwings MartyEwings merged commit a6d8b44 into puppetlabs:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants