(ORCH-1232) Add a standard function for marking strings for extraction #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the only way to mark a string for extraction was to either use a translation function or use a project-specific marker function and update the make target accordingly. This commit provides a standard i18n/mark function which has no behavior beyond returning its argument, but which serves as a designated way to extract strings without translating them. This is important for cases where the string needs to be translated dynamically but is defined at compile time. In particular, it allows for commonly-used strings to be defined in a variables and used in multiple places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only way to mark a string for extraction was to either
use a translation function or use a project-specific marker function and
update the make target accordingly. This commit provides a standard
i18n/mark function which has no behavior beyond returning its argument,
but which serves as a designated way to extract strings without
translating them.
This is important for cases where the string needs to be translated
dynamically but is defined at compile time. In particular, it allows for
commonly-used strings to be defined in a variables and used in multiple
places.