Included file path is based on including file directory #114
Conversation
…d file path is either an absolut path or a relative path based on the path of a.conf. Before this change, work-directory is the base path of included file.
|
Waiting for CLA signature by @SeaTalk @SeaTalk - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
|
CLA signed by all contributors. |
|
No report from trvis-ci yet. Don't know what I am supposed to do. 🤔 |
|
I'll check up on Travis CI. |
|
Our linter is complaining about a few things. |
| @@ -9,6 +9,31 @@ This is a port of the TypesafeConfig library to C++. | |||
|
|
|||
| The library provides C++ support for the [HOCON configuration file format](https://github.com/typesafehub/config/blob/master/HOCON.md). | |||
|
|
|||
| ## I Made Some Change | |||
There was a problem hiding this comment.
This probably makes more sense as the commit message rather than part of the README.
| @@ -0,0 +1,26 @@ | |||
| #include <hocon/parser/config_document_factory.hpp> | |||
There was a problem hiding this comment.
This should be moved to the lib/test directory and integrated with our test suite.
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
All of example/conf and imgs/ seem like they should be part of the test suite as well.
| if (nullptr == fpath) { | ||
| fpath = make_shared<full_path_operator>(); | ||
| } | ||
| extract_filename_from_path(file_basename, &file_dir, &file_name); |
There was a problem hiding this comment.
My instinct is that this isn't the place we should be fixing this, but it'd take some work for me to follow up on.
From a quick glance at https://github.com/lightbend/config/blob/7b9e1539dd46385e9b83be43c4112a448129ac2f/config/src/main/java/com/typesafe/config/impl/Parseable.java#L639-L655, I think the mistake may be in not overriding relative_to on parseable_file (and possibly others) in https://github.com/puppetlabs/cpp-hocon/blob/master/lib/src/parseable.cc.
There was a problem hiding this comment.
I left some pretty high-level comments. Do you have an interest in trying to improve this, or should we consider this an open problem for someone to build on your solution?
Thanks for code-reviewing and comments. I think we could left the problem open before solved. And I'll keep trying to figure another way out to fix it. Thanks again~
It's 3 in the morning and I need some sleep. Good day!
|
Closed in favor of the other PR. |
This change is motivated by incorrect outputs when I use cpp-hocon to parse our conf files.
U can find more details by clicking this link about what situation I ran into.
I wonder whether someone ever been where I am, and I think may be this change could also be a solution to them.