This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
(FM-7383) allow device manager to work with Puppet 6 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Franklin
force-pushed
the
puppet6_cert
branch
from
32b4363
to
5424fd6
Compare
Puppet 6.0.0 removed `puppet cert` and it is now part of `puppetserver ca`. This PR changes the behaviour to use `puppetserver ca sign/list` when running on Puppet 6.0.0 and above. ssl_host suitable algorithms array was also removed, so referencing the array directly to overcome this behaviour as no mention in Puppet 6.0.0 as to where it was moved too.
Thomas-Franklin
force-pushed
the
puppet6_cert
branch
from
5424fd6
to
ba43b43
Compare
Thomas-Franklin
changed the title
tkishel
reviewed
Sep 21, 2018
| @@ -42,8 +42,7 @@ def read_device_certificate_fingerprints(cert_name) | |||
| return nil unless certificate | |||
| fingerprints = {} | |||
| fingerprints['default'] = certificate.fingerprint | |||
| ssl_host = Puppet::SSL::Host.new | |||
| mdas = ssl_host.suitable_message_digest_algorithms | |||
| mdas = [:SHA1, :SHA224, :SHA256, :SHA384, :SHA512] # ssl_host.suitable_message_digest_algorithms was removed in Puppet 6, specifying the array directly | |||
There was a problem hiding this comment.
If we are interested in a 'canonical' list, suitable_message_digest_algorithms appears to have moved to default_digest_algorithm in Puppet 6.0; and is FIPS-aware, as per PUP-8021:
https://github.com/puppetlabs/puppet/blob/6.0.x/lib/puppet/defaults.rb
mdas = Puppet.valid_digest_algorithms
Defaults in Puppet 6.0 also offers Puppet.default_digest_algorithm which may be enough to satisfy FM-7115.
There was a problem hiding this comment.
this is being addressed in #29
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 6.0.0 removed
puppet certand it is now part ofpuppetserver ca. This PR changes the behaviour to usepuppetserver ca sign/listwhen running on Puppet 6.0.0 and above.ssl_host suitable algorithms array was also removed, so referencing the array directly to overcome this behaviour as no mention in Puppet 6.0.0 as to where it was moved too.